Separate device factory into a creator layer #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive connection costs can be incurred once, for device types such as cloud storage. Process now is: (1) Instantiate a factory creator (2) Ask creator for a factory, given a base path (2) Ask factory for devices
This was referenced Jan 28, 2025
|
Note: It seems that the AzureStreamProvider currently creates its own "factory creator" using the provided connection string (even before GarnetServerOptions are created), so it is possible we instantiate the connection twice in case user were importing/exporting the config file from Azure. Ideally we would pass in a shared azure storage factory creator to the stream provider and use the same for GarnetServerOptions. But this seems to be a rare case, so did not optimize for it. |
TalZaccai
approved these changes
Feb 7, 2025
| @@ -277,9 +277,9 @@ public class GarnetServerOptions : ServerOptions | |||
| public int NetworkConnectionLimit = -1; | |||
|
|
|||
| /// <summary> | |||
| /// Creator of device factories | |||
| /// Func to help create device factories | |||
There was a problem hiding this comment.
nit: looks like the comment wasn't updated properly?
| readonly bool readOnly; | ||
| readonly ILogger logger; | ||
|
|
||
| public LocalStorageNamedDeviceFactoryCreator(bool preallocateFile = false, bool deleteOnClose = false, bool disableFileBuffering = true, int? throttleLimit = null, bool useNativeDeviceLinux = false, bool readOnly = false, ILogger logger = null) |
There was a problem hiding this comment.
Would be nice to have an XML comment that describes each parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate device factory into a creator layer so that expensive connection costs can be incurred once, for device types such as cloud storage. Workflow now is:
(1) Instantiate a factory creator
(2) Ask creator for a factory, given a base path
(2) Ask factory for devices instances
Fixes #739.